This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Do not delete e2e test resources on PR builds #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinagesh
force-pushed
the
vinagesh/pipeline
branch
3 times, most recently
from
e3cea50 to
dcd3401
Compare
vinagesh
force-pushed
the
vinagesh/pipeline
branch
13 times, most recently
from
6bca383 to
2f862e5
Compare
vinagesh
changed the title
vinagesh
force-pushed
the
vinagesh/pipeline
branch
from
2f862e5 to
372147a
Compare
vinagesh
commented
Aug 23, 2021
| @@ -29,7 +29,7 @@ internal class Parameters | |||
| 'd', | |||
| "DevicePrefix", | |||
| Required = false, | |||
| Default = "RegistryManagerSample-", | |||
There was a problem hiding this comment.
Changing to match prefix style used. This was not in the delete list earlier but the sample deletes the device so this is just to guard against leaked resources. Currently the hub does not have any devices with this prefix so we don't need to worry about deleting the ones with old prefix.
vinagesh
commented
Aug 23, 2021
| @@ -65,8 +69,29 @@ private async Task CleanupDevices() | |||
| excludeKeysInExport: true, | |||
| storageAuthenticationType: StorageAuthenticationType.KeyBased); | |||
|
|
|||
| JobProperties exportAllDevicesJob = await _registryManager.ExportDevicesAsync(exportAllDevicesProperties); | |||
| JobProperties exportAllDevicesJob = null; | |||
There was a problem hiding this comment.
Adding retries on jobs to protect against any currently running job. We could change the total wait time if necessary after observing for a while.
vinagesh
force-pushed
the
vinagesh/pipeline
branch
from
372147a to
37a4814
Compare
vinagesh
commented
Aug 23, 2021
| @@ -53,6 +53,10 @@ jobs: | |||
| IOTHUB_PFX_X509_THUMBPRINT: $(IOTHUB-PFX-X509-THUMBPRINT) | |||
| DPS_IDSCOPE: $(DPS-IDSCOPE) | |||
| PROVISIONING_CONNECTION_STRING: $(PROVISIONING-CONNECTION-STRING) | |||
| # PATH-TO-DEVICE-PREFIX-FOR-DELETION-FILE is a variable configured on the pipeline. The possible values are: csharp_devices_list.csv, csharp_samples_devices_list.csv. | |||
There was a problem hiding this comment.
This variable is no longer a constant and no longer extracted from keyvault.
https://github.com/Azure/azure-iot-sdk-csharp/pull/2153/files
vinagesh
requested review from
abhipsaMisra,
azabbasi,
barustum,
drwill-ms,
jamdavi and
timtay-microsoft
as code owners
timtay-microsoft
approved these changes
Aug 24, 2021
drwill-ms
reviewed
Aug 24, 2021
drwill-ms
reviewed
Aug 24, 2021
drwill-ms
reviewed
Aug 24, 2021
iot-hub/Samples/service/CleanupDevicesSample/CleanupDevicesSample.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Aug 24, 2021
vinagesh
force-pushed
the
vinagesh/pipeline
branch
from
37a4814 to
15411c1
Compare
vinagesh
force-pushed
the
vinagesh/pipeline
branch
from
15411c1 to
b768e2d
Compare
drwill-ms
approved these changes
Aug 24, 2021
vinagesh
added a commit
that referenced
this pull request
Aug 24, 2021
vinagesh
added a commit
that referenced
this pull request
Aug 24, 2021
* Do not delete e2e test resources on PR builds (#227) * Remove barustum from CODEOWNERS (#224) Co-authored-by: Basel Rustum <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly moves the configuration of which devices to delete to the pipeline variable rather than a constant value. Once this is checked in, the scheduled run will run as normal, running all tests and cleaning up both e2e and sample created devices.
Apart from that pipeline, I"ll add a new pipeline that will only delete the sample created devices along with running the samples. This pipeline will be enabled on PR builds.
After this is complete, I will make merge these changes to preview branch and create a PR pipeline for the preview branch as well.